Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Chocolatey shims (chocolatey, cinst, clist, cpush, cuninst, cup) #2642

Closed
gep13 opened this issue Mar 10, 2022 · 9 comments · Fixed by #3074 or #3082
Closed

Remove deprecated Chocolatey shims (chocolatey, cinst, clist, cpush, cuninst, cup) #2642

gep13 opened this issue Mar 10, 2022 · 9 comments · Fixed by #3074 or #3082

Comments

@gep13
Copy link
Member

gep13 commented Mar 10, 2022

In v1.0.0 we marked the Chocolatey shims as deprecated

  • chocolatey
  • cinst
  • clist
  • cpush
  • cuninst
  • cup

These now need to be removed completely.

Usage of these shims should be removed from the help documentation, and the genaratedocs.ps1 file should be updated to remove the explicit warnings about their removal in 2.0.0.

This is a follow up issue from this one in the 1.0.0 milestone: #2641

@gep13
Copy link
Member Author

gep13 commented Mar 17, 2023

@vexx32 I have a branch in the making that has these changes on it.

gep13 added a commit to gep13/choco that referenced this issue Mar 17, 2023
The shims for chocolatey, cinst, clist, cpush, cuninst, and cup, where
deprecated in a previous release of Chocolatey, and this commit removes
them, so that they will not appear in the upcoming 2.0.0 release.

Also the documentation around the deprecations have been removed, and
tests updated to reflect that these shims are no longer included.
@gep13 gep13 linked a pull request Mar 17, 2023 that will close this issue
9 tasks
corbob pushed a commit to gep13/choco that referenced this issue Mar 17, 2023
The shims for chocolatey, cinst, clist, cpush, cuninst, and cup, where
deprecated in a previous release of Chocolatey, and this commit removes
them, so that they will not appear in the upcoming 2.0.0 release.

Also the documentation around the deprecations have been removed, and
tests updated to reflect that these shims are no longer included.
corbob pushed a commit to gep13/choco that referenced this issue Mar 17, 2023
The shims for chocolatey, cinst, clist, cpush, cuninst, and cup, where
deprecated in a previous release of Chocolatey, and this commit removes
them, so that they will not appear in the upcoming 2.0.0 release.

Also the documentation around the deprecations have been removed, and
tests updated to reflect that these shims are no longer included.
corbob added a commit that referenced this issue Mar 17, 2023
@sebma
Copy link

sebma commented Mar 17, 2023

@gep13 Hi, these shims really came handy.

Do you know any replacement for those ?

@vexx32
Copy link
Member

vexx32 commented Mar 17, 2023

@sebma if using PowerShell, you can always define functions to replace them in your profile. For example:

function cinst {
    choco install @args
}

There's probably a way to do similar by adding a few custom batch files to a folder on your PATH, but I don't recall offhand what that looks like.

@sebma
Copy link

sebma commented Mar 18, 2023

@vexx32 Thanks for the function. I guess I will have to do on every new chocolatay install.

@gep13
Copy link
Member Author

gep13 commented Mar 19, 2023

Nothing to stop you creating a package with these commands, and installing that package on initial installation.

@sebma
Copy link

sebma commented Mar 20, 2023

@gep13 You're right. I will have to learn how to do that.

You wrote :

These now need to be removed completely.

One last question : Why ?

@gep13
Copy link
Member Author

gep13 commented Mar 20, 2023

@sebma said:
One last question : Why ?

This was done for consistency in terms of usage of Chocolatey.

In the 1.0.0 release of Chocolatey, we removed the cpack alias due to a conflict with the CMake application. You can find details about that here:

#89

Given that we are not able to have the cpack alias, the decision was taken to defer to default to using the choco command everywhere, and being very explicit about its usage. In addition, it is a simple matter to add the PowerShell aliases for those folks who want to continue to use them.

corbob added a commit to corbob/choco that referenced this issue Mar 20, 2023
Ensure we ignore unsigned shims on upgrade.
corbob added a commit to corbob/choco that referenced this issue Mar 20, 2023
Ensure we ignore unsigned shims on upgrade.
corbob added a commit to corbob/choco that referenced this issue Mar 20, 2023
Ensure we ignore unsigned shims on upgrade.
gep13 added a commit that referenced this issue Mar 20, 2023
(#2642) Ensure unsigned shims aren't removed.
@gep13 gep13 added 4 - Done and removed 3 - Review labels Mar 21, 2023
@gep13 gep13 changed the title Remove deprecated Chocolatey shims (chocolatey. cinst, clist, cpush, cuninst, cup) Remove deprecated Chocolatey shims (chocolatey, cinst, clist, cpush, cuninst, cup) Mar 21, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@jeremyj563
Copy link

For anyone like myself who wants these shims back: https://community.chocolatey.org/packages/choco-shim-redirects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants