Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

license - Expired licenses should not cause Chocolatey errors #1500

Closed
gep13 opened this issue Feb 20, 2018 · 2 comments
Closed

license - Expired licenses should not cause Chocolatey errors #1500

gep13 opened this issue Feb 20, 2018 · 2 comments
Assignees
@gep13
Labels
5 - Released Bug Customer Pro/Business
Milestone
0.10.9

Comments

@gep13
Copy link
Member

gep13 commented Feb 20, 2018

If there is an expired Chocolatey license file present in the license folder, Chocolatey will correctly validate this, and handle it based on feature, however, by default, the licensing system we are using will attempt to re-validate the license every 5 minutes. This can cause problems on longer running Chocolatey processes.

This re-validation is not required.
@gep13 gep13 added this to the 0.10.9 milestone Feb 20, 2018
@gep13 gep13 self-assigned this Feb 20, 2018
gep13 added a commit to gep13/choco that referenced this issue Feb 20, 2018
@gep13
(chocolateyGH-1500) Disable re-validation of Chocolatey License File
e9481af 
- This isn't required, the license is asserted on each choco command
gep13 added a commit to gep13/choco that referenced this issue Feb 20, 2018
@gep13
(chocolateyGH-1500) Disable re-validation of Chocolatey License File
69102ab 
- This isn't required, the license is asserted on each choco command
@gep13 gep13 mentioned this issue Feb 20, 2018
Merged
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
Merge pull request #1501 from gep13/ExpiredLicenseIssue
7e58483 
(GH-1500) Disable re-validation of Chocolatey License File
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
Merge branch 'stable'
cdf0938 
* stable: (35 commits)
  (GH-1478) Upgrade 7z to 18.1
  (GH-1490) Remove quotes/apostrophes surrounding parameter
  (maint) virtualize get_package_information
  (maint) virtualize all calls in NuGetService
  (GH-100) Log without colorization
  (GH-100) add no color feature/option
  (GH-100) add no color log4net config files
  (maint) formatting
  (#1489) Log PowerShell contents w/out formatting
  (maint) Some options could be achieved w/FOSS
  (maint) Add instructions for strong naming NuGet
  (maint) update licensing code
  (GH-1488) License validation logging
  (specs) add pack scenario nuspec
  (maint) Whitespace changes
  (GH-1500) Disable re-validation of Chocolatey License File
  (doc) update etiquette statement
  (build) allow builds with any .NET 4.x
  (doc) update licensed changelog
  (maint) update licensing
  ...

# Conflicts:
#	README.md
@ferventcoder
Copy link
Member

ferventcoder commented Feb 20, 2018 •
edited
Loading

Merged into stable at 7e58483, will release in 0.10.9.

@ferventcoder ferventcoder changed the title Expired License should not fail Chocolatey License - Expired license should not fail Chocolatey Feb 20, 2018
@ferventcoder ferventcoder changed the title License - Expired license should not fail Chocolatey License - Expired licenses should not cause Chocolatey failures Mar 4, 2018
@ferventcoder ferventcoder changed the title License - Expired licenses should not cause Chocolatey failures License - Expired licenses should not cause Chocolatey errors Mar 4, 2018
@ferventcoder ferventcoder changed the title License - Expired licenses should not cause Chocolatey errors license - Expired licenses should not cause Chocolatey errors Mar 4, 2018
ferventcoder added a commit that referenced this issue May 4, 2018
@ferventcoder
(GH-1500) Fix - Wrap Write-Host if used in setup
8254592 
When PowerShell functions are used as part of installing Chocolatey
itself, it can cause issues if they call Write-Host. Note all of the
functions that are called from Setup, then wrap any existing with
try/catch.
ferventcoder added a commit that referenced this issue May 4, 2018
@ferventcoder
Merge branch 'stable'
0113db6 
* stable:
  (version) 0.10.11
  (doc) update release notes for 0.10.11
  (GH-1540) Fix - AutoUninstaller can't find escaped quotes
  (GH-1543) Fix - log format error on install location with GUID
  (GH-1500) Fix - Wrap Write-Host if used in setup
  (GH-991) Install - Modify profile if file exists & empty
  (GH-1443) Set original config before loop
  (maint) add a note for GH-1548
  (GH-1557) Upgrade 7z to 18.5
@ferventcoder ferventcoder mentioned this issue May 25, 2018
Closed
@ferventcoder ferventcoder mentioned this issue Feb 16, 2019
Closed
@ferventcoder
Copy link
Member

This also requires at least Chocolatey Licensed Extension 1.12.12 for it to work properly. This is whether or not the license loads the binaries, it will trigger the recheck.

@steviecoaster steviecoaster mentioned this issue Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released Bug Customer Pro/Business
Projects
None yet
Milestone
0.10.9
Development

No branches or pull requests
2 participants
@ferventcoder @gep13