(#153) Enable FIPs if required #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviecoaster
added
the
3 - Review
JPRuskin
reviewed
Oct 11, 2024
If we detect that FIPS is enabled on a system when we install Chocolatey, we should also configure Chocolatey to use FIPs-compliant checksums. Without enabling this feature, package installations will fail as Chocolatey will not use a compliant hashing mechanism.
The Pester package breaks when you internalize it, due to the added code at the top of the chocolateyInstall script. This commit ensures the package is not internalized.
|
Added a little fix for the Pester issue we were seeing. Turns out, internalization really really hates param blocks and begin/process/end. I'll create a support issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we detect that FIPs is enabled on a system when we
install Chocolatey, we should also configure Chocolatey
to use FIPs-compliant checksums. Without enabling this
feature, package installations will fail as Chocolatey
will not use a compliant hashing mechanism.
Description Of Changes
This change adds detection for FIPs and sets Chocolatey configuration to use FIPS compliant checksums if FIPs is detected to be enabled
Motivation and Context
When FIPs is enabled, Chocolatey does not use a checksum mechanism that is strong enough to meet the requirements of FIPs security.
Testing
Tested locally in AutomatedLab and confirmed when FIPs is enabled, chocolatey configures FIPs compliant checksums.
Operating Systems Testing
Server 2022
Change Types Made
Change Checklist
Related Issue
Fixes #153