Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(php) Extending php package functionality #548

Merged
merged 11 commits into from
Feb 3, 2017
Merged

(php) Extending php package functionality #548

merged 11 commits into from
Feb 3, 2017

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Jan 25, 2017 •
edited
Loading

Changes

@AdmiringWorm AdmiringWorm mentioned this pull request Feb 1, 2017
Closed
@AdmiringWorm
(php) Allow install directory overrides
6d7c5dc
@AdmiringWorm
(php) Changed before modify script to move instead of copy
7924859
@AdmiringWorm
(php) Multiple fixes
36e1a9a 
* Changed configuration script to just move from old directory
* Fixed uninstall path helper function
* Removed beforemodify script, and use the function directory in install/uninstall scripts
@AdmiringWorm
(php) Added option to opt-out of path env adding
302080f
@AdmiringWorm
Copy link
Member Author

@chocolatey/chocolateycommunitypackages anyone up for reviewing this PR?

ferventcoder
ferventcoder reviewed Feb 2, 2017
View reviewed changes
automatic/php/php.nuspec

## Package Parameters
- `/DontAddToPath` - Do not add install directory to path
- `/InstallDir:` - Override the installation directory (needs to be specified both during install and update, until it is remembered by choco)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe - the underlying installer may remember where it is installed for upgrades

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package doesn't use any installer, it uses the provided zip archives.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right on!

pascalberger
pascalberger approved these changes Feb 3, 2017
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit 302080f into master Feb 3, 2017
@AdmiringWorm AdmiringWorm deleted the php branch February 3, 2017 21:12
@photodude photodude mentioned this pull request Feb 12, 2017
Closed
@photodude
Copy link
Contributor

@AdmiringWorm Is there a guide somewhere that would explain how to use the side-by-side switch install -m for Installing to a versioned install directory? I'm trying to understand how to implement that on AppVeyor for caching different installs like php 7 vs PHP 7.1.

@AdmiringWorm
Copy link
Member Author

AdmiringWorm commented Feb 12, 2017 •
edited
Loading

@photodude
Do allow side by side installation I think there is enough to just pass the following:
choco install -m php --version {version} --params '"/InstallDir:{Path}"'
it is possible that you may have to use the --force argument as well, but not sure about that.

Do note though, the changes to add support for side-by-side installation have not yet been made available for the following versions: 7.0.x and 5.6.x.

EDIT:
just pushed the changes for 7.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferventcoder ferventcoder ferventcoder left review comments

@pascalberger pascalberger pascalberger approved these changes

Assignees
No one assigned
Labels
4 - Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdmiringWorm @photodude @ferventcoder @pascalberger