Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameSite cookie parameter #11

Closed
chmike opened this issue Sep 25, 2017 · 7 comments
Closed

Add SameSite cookie parameter #11

chmike opened this issue Sep 25, 2017 · 7 comments

Comments

@chmike
Copy link
Owner

chmike commented Sep 25, 2017

The SameSite cookie parameter allows to reduce the risk of CSRF attacks if the remote browser takes it in account.

@chmike
Copy link
Owner Author

chmike commented Aug 26, 2018

This change is postponed until the SameSite cookie parameter is official. It is currently only a draft RFC.

@agentabstract
Copy link

Giving this a bump. I'm getting console errors in firefox and I actually came to your page to check on this. Love your package I'm using it at work.

@chmike
Copy link
Owner Author

chmike commented Aug 12, 2020

Hello and thank you for the feedback on the package. I'll work on it as soon as possible.

chmike added a commit that referenced this issue Aug 14, 2020
@chmike
Copy link
Owner Author

chmike commented Aug 14, 2020

The SameSite parameter has been added with the release v1.3.0.

@chmike chmike closed this as completed Aug 14, 2020
@agentabstract
Copy link

agentabstract commented Aug 14, 2020 via email

@chmike
Copy link
Owner Author

chmike commented Aug 14, 2020

If I understood correctly, you need to set SameSite to None to allow third party cookie. But this will only work if the Secure parameter is set to true. The cookie will thus be only returned to https requests.

@agentabstract
Copy link

agentabstract commented Aug 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants