This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Add a data structure for memory conf reading and writing #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardcwang
reviewed
Feb 28, 2019
|
|
||
| def apply(s: String): Option[MemPort] = MemPort.all.find(_.name == s) | ||
|
|
||
| def fromString(s: String): Seq[MemPort] = { |
There was a problem hiding this comment.
Some scaladoc may be useful here; it appears that s is meant to be a comma-delimited list of port types?
|
|
||
| val regex = raw"\s*name\s+(\w+)\s+depth\s+(\d+)\s+width\s+(\d+)\s+ports\s+([^\s]+)\s+(?:mask_gran\s+(\d+))?\s*".r | ||
|
|
||
| def fromString(s: String): Seq[MemConf] = { |
There was a problem hiding this comment.
Scaladoc indicating that this takes in a string containing multiple lines delimited by \n?
|
Do you think it would be difficult to add a test of this memory configuration stuff? |
|
It shouldn't be too hard. I will add some. |
This provides a data structure wrapper around the existing memory conf format which contains both reading and writing methods, making it easier to write code that needs to read the format.
…of a Seq[MemPort] which is a bit less fragile.
|
@azidar Done. Let me know if you want anything else. |
azidar
approved these changes
Mar 7, 2019
azidar
added
the
Please Merge
albertchen-sifive
pushed a commit
to albertchen-sifive/firrtl
that referenced
this pull request
Mar 18, 2019
…ce#1041) * Copy MemConf.scala from ucb-bar/barstools#35 into memlib. This provides a data structure wrapper around the existing memory conf format which contains both reading and writing methods, making it easier to write code that needs to read the format. * Add MemConf tests and use a Map[MemPort, Int] for port lists instead of a Seq[MemPort] which is a bit less fragile.
ucbjrl
pushed a commit
that referenced
this pull request
Mar 26, 2019
* Copy MemConf.scala from ucb-bar/barstools#35 into memlib. This provides a data structure wrapper around the existing memory conf format which contains both reading and writing methods, making it easier to write code that needs to read the format. * Add MemConf tests and use a Map[MemPort, Int] for port lists instead of a Seq[MemPort] which is a bit less fragile.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a data structure wrapper around the existing memory conf format which contains both reading and writing methods, making it easier to write code that needs to read the format. This should produce identical .conf files to the existing code, so it should be fully backward-compatible. From ucb-bar/barstools#35