Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge bin #991

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Purge bin #991

merged 1 commit into from
Jan 19, 2019

Conversation

ducky64
Copy link
Contributor

@ducky64 ducky64 commented Jan 18, 2019

Related issue: N/A

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes
Purge bin/ directory which doesn't seem to be used by anything anymore.

@ducky64 ducky64 added this to the 3.2.0 milestone Jan 18, 2019
@ducky64 ducky64 self-assigned this Jan 18, 2019
@ducky64 ducky64 requested a review from jackkoenig January 18, 2019 23:56
@ducky64 ducky64 requested a review from a team as a code owner January 18, 2019 23:56
edwardcwang
edwardcwang approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the great purge?

@ducky64
Copy link
Contributor Author

ducky64 commented Jan 19, 2019

It is a great (and long overdue) purge.

@ducky64 ducky64 merged commit 3b3405e into master Jan 19, 2019
@ducky64 ducky64 deleted the purge branch January 19, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardcwang edwardcwang edwardcwang approved these changes

@jackkoenig jackkoenig Awaiting requested review from jackkoenig

Assignees

@ducky64 ducky64

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ducky64 @edwardcwang