Fix scaladoc for UInt.unary_! #987
Conversation
|
My bad... Width inference really does work. Warning: there may be more errors in this Scaladoc. These were all updated at once and the size of |
|
Ack. I'll do a quick sanity check on the others in that file. |
|
Thanks, @aswaterman. I appreciate that. |
|
The width behavior of UInt << UInt is slightly wrong, and the description of UInt.asSInt is correct but a little vague. Fixing. |
|
Looks like unary_- has the wrong width description, too - these are truncating but described as expanding. Fixing. |
It performs the operation (x === 0.U), just like in C. The scaladoc incorrectly described it as performing the operation !x(0). (Obviously, these are equivalent for Bool, but not for UInt in general).
aswaterman
force-pushed
the
unary-not-fix
branch
from
1436430 to
62879d1
Compare
|
@seldridge please re-review |
|
@ucbjrl any idea why Jenknis is hung up? |
|
Yes and no. We occasionally experience deadlocks with the OpenJDK JVM on the millennium machines. It's not clear if this is a JVM or a Linux problem. A FUTEX_WAIT kernel bug has been reported (and fixed) several times. Recent reports indicate it may now be a JVM issue. I'll kill the hung Jenkins jobs. |
|
... and set some timeouts for the Jenkins jobs. |
|
Interesante. |
It performs the operation (x === 0.U), just like in C. The scaladoc incorrectly described it as performing the operation !x(0). (Obviously, these are equivalent for Bool, but not for UInt in general).
Related issue:
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes