Change InlineSpec to expect "_" and not "$" #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
approved these changes
Sep 27, 2018
seldridge
force-pushed
the
fix-inlining
branch
from
9f0ebca to
d8b9e36
Compare
A FIRRTL change to inlining changes the inlined instance delimiter to "_" from "$". This change is reflected here in an update to the associated Chisel tests for the Inline API. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
fix-inlining
branch
from
d8b9e36 to
1f24aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the InlineSpec tests so that they pass after FIRRTL inlining is changed to use
_as a delimiter.Related PR: chipsalliance/firrtl#901
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation