Inhibit aggressive resource file name mangling. #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses #883.
ucbjrl
added
release issue
Bugfix
jackkoenig
reviewed
Aug 28, 2018
| val additionalVFiles = additionalVResources.map((name: String) => { | ||
| val mangledResourceName = name.replace("/", "_") | ||
| // Don't convert a leading '/' to an '_'. Just skip the leading '/'. | ||
| val nameWithoutLeadingSlash = if (name(0) == '/') name.substring(1) else name |
There was a problem hiding this comment.
Not a big deal but you could just use name.stripPrefix("/")
|
To ensure that we use the same file names for explicitly included resources and those discovered by the BlackBoxSourceHelper, I'm updating this to use a common method. This PR will then depend on chipsalliance/firrtl#882 and shouldn't be merged until that FIRRTL PR is merged. |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #883.
Type of change: bug report
Impact: API modification
Although this should have minimal impact on existing code, it is observable.
Development Phase: implementation
Release Notes
Minimize the name mangling of output resource files.