Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify tag #806

Closed
wants to merge 1 commit into from
Closed

specify tag #806

wants to merge 1 commit into from

Conversation

horie-t
Copy link

@horie-t horie-t commented Apr 15, 2018

below will cause "detached HEAD".

$ git checkout verilator_3_904
Note: checking out 'verilator_3_904'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

git checkout -b

HEAD is now at 02530172... Version bump
$ git status
HEAD detached at verilator_3_904
nothing to commit, working tree clean

Related issue:

Type of change: bug report | feature request | other enhancement

Impact: no functional change | API addition (no impact on existing code) | API modification

Development Phase: proposal | implementation

Release Notes

below will cause "detached HEAD".

$ git checkout verilator_3_904
Note: checking out 'verilator_3_904'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 02530172... Version bump
$ git status
HEAD detached at verilator_3_904
nothing to commit, working tree clean
@ghost
Copy link

ghost commented Apr 15, 2018

Can one of the admins verify this patch?

@edwardcwang
Copy link
Contributor

Is there anything particularly undesirable with the (temporary) Verilator repo being in detached HEAD?

@horie-t
Copy link
Author

horie-t commented Apr 24, 2018

detached HEAD(is same main branch) cause undesirable like below link

ekiwi/pynq#1

@ucbjrl
Copy link
Contributor

ucbjrl commented May 18, 2018

The fact that git reports

$ git status
HEAD detached at verilator_3_904
nothing to commit, working tree clean

has nothing to do with the failure reported by ekiwi/pynq#1. That failure was due to the usage of a version of verilator which was incompatible with the test harness generated by chisel.

We are only checking out verilator (at a specific tag) in order to build that version of it; we are not planning on making any changes to the source code. There is no need to create a branch.

If at some subsequent time you should decide to debug verilator and wish to work on a branch, you can do a:

$ git checkout -b mydebugVerilator

which will create a new branch from the detached HEAD. You may then use git to record your history of changes to that new branch.

@ucbjrl ucbjrl closed this May 18, 2018
@zhutmost
Copy link

zhutmost commented Jul 7, 2018

Hi, developers. Can the verilator dependency upgrade from v3.904 to v3.924 or other newer version?
v3.904 have some conflicts with the latest systemC (2.3.2)?

Thanks a lot.

@edwardcwang
Copy link
Contributor

Could you check if all the Chisel unit tests still pass with v3.924 or a newer version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants