Fix widths for literal values in Bundle literals #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation.
mwachs5
approved these changes
May 23, 2024
seldridge
approved these changes
May 23, 2024
| @@ -122,7 +122,6 @@ private[chisel3] object ir { | |||
| } | |||
|
|
|||
| /** Provides a mechanism that LitArgs can have their width adjusted | |||
| * to match other members of a VecLiteral | |||
There was a problem hiding this comment.
Not stray actually, I am calling the function from Bundle literals now lol.
|
Super annoyingly, the check for literals being too wide causes things to fail. This is basically a case of implicit truncation. Instead of erroring on it, I'm going to just truncate in this PR (since this will backport to 3.6.x). I will then follow with a PR that turns it into a warning for master and 6.x |
This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel.
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
* Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57) # Conflicts: # core/src/main/scala/chisel3/internal/firrtl/IR.scala # src/test/scala/chiselTests/BundleLiteralSpec.scala # src/test/scala/chiselTests/ConnectableSpec.scala # src/test/scala/chiselTests/VecLiteralSpec.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
* Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57) # Conflicts: # core/src/main/scala/chisel3/internal/firrtl/IR.scala # src/test/scala/chiselTests/ConnectableSpec.scala # src/test/scala/chiselTests/VecLiteralSpec.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
* Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57)
14 tasks
14 tasks
jackkoenig
added a commit
that referenced
this pull request
May 23, 2024
* Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57) # Conflicts: # core/src/main/scala/chisel3/internal/firrtl/IR.scala # src/test/scala/chiselTests/ConnectableSpec.scala # src/test/scala/chiselTests/VecLiteralSpec.scala
jackkoenig
added a commit
that referenced
this pull request
May 23, 2024
* Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57)
chiselbot
pushed a commit
that referenced
this pull request
May 24, 2024
) * Fix widths for literal values in Bundle literals (#4082) * Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57) * Waive false binary compatibility failure Also move waivers from files to build.sbt. --------- Co-authored-by: Jack Koenig <[email protected]>
chiselbot
pushed a commit
that referenced
this pull request
May 24, 2024
) * Fix widths for literal values in Bundle literals (#4082) * Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57) # Conflicts: # core/src/main/scala/chisel3/internal/firrtl/IR.scala # src/test/scala/chiselTests/BundleLiteralSpec.scala # src/test/scala/chiselTests/ConnectableSpec.scala # src/test/scala/chiselTests/VecLiteralSpec.scala * Resolve backport conflicts and waive false MiMa failure. --------- Co-authored-by: Jack Koenig <[email protected]>
jackkoenig
added a commit
that referenced
this pull request
May 24, 2024
* Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57) # Conflicts: # core/src/main/scala/chisel3/internal/firrtl/IR.scala # src/test/scala/chiselTests/ConnectableSpec.scala # src/test/scala/chiselTests/VecLiteralSpec.scala
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
May 24, 2024
) * Fix widths for literal values in Bundle literals (#4082) * Fix widths for literal values in Bundle literals Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. * Implicitly truncate too-wide literals in Bundle literals This is to fix a bug in concatenation without breaking things relying on implicit truncation. This will be a warning in newer versions of Chisel. (cherry picked from commit 3939e57) # Conflicts: # core/src/main/scala/chisel3/internal/firrtl/IR.scala # src/test/scala/chiselTests/ConnectableSpec.scala # src/test/scala/chiselTests/VecLiteralSpec.scala * Waive false binary compatibility failure Also move waivers from files to build.sbt. --------- Co-authored-by: Jack Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Previously, the user-specified (or unspecified minimum width) of the literal would be used in some operations like concatenation. For literal values that are too-wide, they will now truncate to the correct width. This will become a warning (then later an error) in newer major versions of Chisel.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.