-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension points on Data for customizing Connectable behavior. #3978
Conversation
670dd4c
to
64aac0a
Compare
The user can override these methods to customize how their Data applies waive, squeeze, and exclude in its Connectable.
64aac0a
to
2f73a94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works hierarchically, see comments.
c539212
to
23b9caf
Compare
8e08180
to
fafa353
Compare
Generally LGTM assuming there isn't too much of a performance penalty (I think it's probably okay). Nice tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM one minor comment about possibly unused imports
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
The user can override these methods to customize how their Data applies waive, squeeze, and exclude in its Connectable.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.