Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension points on Data for customizing Connectable behavior. #3978

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

The user can override these methods to customize how their Data applies waive, squeeze, and exclude in its Connectable.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Apr 9, 2024
@mikeurbach mikeurbach added this to the 7.0 milestone Apr 9, 2024
@mikeurbach mikeurbach force-pushed the mikeurbach/customize-connectable branch from 670dd4c to 64aac0a Compare April 9, 2024 16:47
The user can override these methods to customize how their Data
applies waive, squeeze, and exclude in its Connectable.
@mikeurbach mikeurbach force-pushed the mikeurbach/customize-connectable branch from 64aac0a to 2f73a94 Compare April 9, 2024 16:55
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works hierarchically, see comments.

@mikeurbach mikeurbach force-pushed the mikeurbach/customize-connectable branch from c539212 to 23b9caf Compare April 10, 2024 00:49
@mikeurbach mikeurbach force-pushed the mikeurbach/customize-connectable branch from 8e08180 to fafa353 Compare April 10, 2024 01:18
@jackkoenig
Copy link
Contributor

Generally LGTM assuming there isn't too much of a performance penalty (I think it's probably okay). Nice tests!

@mikeurbach mikeurbach marked this pull request as ready for review April 11, 2024 15:16
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one minor comment about possibly unused imports

@mikeurbach mikeurbach merged commit 1ecab68 into main Apr 11, 2024
14 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/customize-connectable branch April 11, 2024 20:11
SpriteOvO pushed a commit that referenced this pull request Apr 20, 2024
)

The user can override this method to customize how their Data
applies waive, squeeze, and exclude in its Connectable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants