Support literals in DataView #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
(cherry picked from commit ce05462) # Conflicts: # src/test/scala/chiselTests/experimental/DataView.scala
28 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
(cherry picked from commit ce05462)
28 tasks
chiselbot
pushed a commit
that referenced
this pull request
Apr 4, 2024
(cherry picked from commit ce05462) Co-authored-by: Jack Koenig <[email protected]>
chiselbot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* Support literals in DataView (#3964) (cherry picked from commit ce05462) # Conflicts: # src/test/scala/chiselTests/experimental/DataView.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <[email protected]>
SpriteOvO
added a commit
that referenced
this pull request
Apr 6, 2024
* Specify right convention for modules * Specify `desiredName` as `defname` for `extmodule` Removed FixedPoint in muxes-and-input-selection.md (#3956) Make SRAMs directly emit FIRRTL memories (#3955) Add a new BoringUtils.drive API for boring to drive a sink. (#3960) This API allows users to bore to a sink they plan to drive, which complements the existing API to bore from a source to read. Support literals in DataView (#3964) Add requireIsAnnotatable for better errors when annotating literals (#3968)
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 8, 2024
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 20, 2024
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug with the rename map for non 1-1 views of literals.
Contributor Checklist
docs/src?Type of Improvement
Arguably a Feature or Bugfix, but I lean bugfix.
Desired Merge Strategy
Release Notes
View of literals will now themselves be literals. This also fixes an internal bug related to views of literals.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.