Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely a non-breaking change, but firtool-resolver 2.0.0 is a big change in that it drops a lot of transitive dependencies which could be accidentally relied upon by downstream users. Also, the firtool-resolver API changed types for its Logger. It used to use scribe, but to reduce dependencies, it has been changed to its own very lightweight Logger API, you can see the simple shim in this PR.
This version will work on 5.x and 3.6.x but sadly should not be backported to 6.x as it does break binary compatibility.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
This change should be non-breaking for the vast majority of users; however, it does have a substantial impact on Chisel's transitive dependencies which could affect some users. The following transitive dependencies were dropped:
Any users experiencing issues should consider manually adding whichever of these dependencies they may be relying on.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.