Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isProperty query in DataMirror. #3783

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

This adds an API to DataMirror to query if a Data is a Property.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This adds an API to DataMirror to query if a Data is a Property.
@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Jan 30, 2024
@mikeurbach mikeurbach mentioned this pull request Jan 30, 2024
14 tasks
@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 30, 2024
@sequencer sequencer added this to the 7.0 milestone Jan 30, 2024
Copy link

linux-foundation-easycla bot commented Jan 30, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mikeurbach / name: Mike Urbach (01fbfac)

@mikeurbach
Copy link
Contributor Author

@sequencer I will plan to add the patches I'm submitting today to the 6.x release branch.

@mikeurbach mikeurbach modified the milestones: 7.0, 6.x Jan 30, 2024
@mikeurbach mikeurbach force-pushed the mikeurbach/property-datamirror branch from 0dd3ba2 to 01fbfac Compare January 30, 2024 18:50
@mikeurbach
Copy link
Contributor Author

I just force pushed to remove the merge commit by mergify.

@mikeurbach mikeurbach removed the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 30, 2024
@mikeurbach mikeurbach force-pushed the mikeurbach/property-datamirror branch from 16f882d to 01fbfac Compare January 30, 2024 18:53
@mikeurbach
Copy link
Contributor Author

Seems like there's a catch-22: if you add Please Merge label, mergify will merge main, but then easy cla will say the bot hasn't signed the agreement and block merging. I will merge this myself once CI passes.

@mikeurbach mikeurbach enabled auto-merge (squash) January 30, 2024 18:55
@mikeurbach mikeurbach merged commit 3b27dcd into main Jan 30, 2024
42 of 44 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/property-datamirror branch January 30, 2024 19:07
@mergify mergify bot added the Backported This PR has been backported label Jan 30, 2024
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
This adds an API to DataMirror to query if a Data is a Property.

(cherry picked from commit 3b27dcd)

# Conflicts:
#	src/test/scala/chiselTests/reflect/DataMirrorSpec.scala
@jackkoenig
Copy link
Contributor

Seems like there's a catch-22: if you add Please Merge label, mergify will merge main, but then easy cla will say the bot hasn't signed the agreement and block merging. I will merge this myself once CI passes.

I thought I had fixed this in #3770, but it seems that only fixed it for backports. That being said, I'm not sure how useful Mergify automerging is considering Github has the automerge feature, maybe we should just remove that flow.

chiselbot pushed a commit that referenced this pull request Jan 30, 2024
* Support isProperty query in DataMirror. (#3783)

This adds an API to DataMirror to query if a Data is a Property.

(cherry picked from commit 3b27dcd)

# Conflicts:
#	src/test/scala/chiselTests/reflect/DataMirrorSpec.scala

* Fix backport merge conflict.

---------

Co-authored-by: Mike Urbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants