-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support isProperty query in DataMirror. #3783
Conversation
This adds an API to DataMirror to query if a Data is a Property.
|
@sequencer I will plan to add the patches I'm submitting today to the 6.x release branch. |
0dd3ba2
to
01fbfac
Compare
I just force pushed to remove the merge commit by mergify. |
16f882d
to
01fbfac
Compare
Seems like there's a catch-22: if you add Please Merge label, mergify will merge main, but then easy cla will say the bot hasn't signed the agreement and block merging. I will merge this myself once CI passes. |
This adds an API to DataMirror to query if a Data is a Property. (cherry picked from commit 3b27dcd) # Conflicts: # src/test/scala/chiselTests/reflect/DataMirrorSpec.scala
I thought I had fixed this in #3770, but it seems that only fixed it for backports. That being said, I'm not sure how useful Mergify automerging is considering Github has the automerge feature, maybe we should just remove that flow. |
* Support isProperty query in DataMirror. (#3783) This adds an API to DataMirror to query if a Data is a Property. (cherry picked from commit 3b27dcd) # Conflicts: # src/test/scala/chiselTests/reflect/DataMirrorSpec.scala * Fix backport merge conflict. --------- Co-authored-by: Mike Urbach <[email protected]>
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
This adds an API to DataMirror to query if a Data is a Property.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.