Bugfix: foo and foo_ names cause incorrect prefix calculation #3600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When naming
foo
, thenfoo_
, the calculation for the prefix offoo_
is incorrect. It should not have a prefix, but instead thinks the entirefoo_
is the prefix. When the prefix is stripped to find the index, you get ajava.lang.NumberFormatException: For input string: ""
, as it tries to convert the empty string to anInt
.This bugfix checks the case where a prefix is calculated, but would return an empty string if stripped.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Naming
foo
and thenfoo_
will no longer trigger an error.Reviewer Checklist (only modified by reviewer)
3.5.x
,3.6.x
, or5.x
depending on impact, API modification or big change:6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.