Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firrtl: Emit under 3.2.0 (not released) to cover property features. #3517

Conversation

dtzSiFive
Copy link
Member

While this doesn't exist, some of the property-related features in-tree don't exist in the claimed 3.1.0.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Backend code generation

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Bump FIRRTL version to unreleased 3.2.0 to cover experimental features emitted.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@seldridge seldridge added the Backend Code Generation Affects backend code generation, will be included in release notes label Sep 1, 2023
@dtzSiFive
Copy link
Member Author

dtzSiFive commented Sep 1, 2023

Error seems unrelated to both this PR and any recent changes on main? Am I missing something?

Whoops the red bold "error" prints may be expected output, missed a test fix 👍 . Should be addressed in latest push.

While this doesn't exist, some of the property-related features
don't exist in the claimed 3.1.0.
@dtzSiFive dtzSiFive force-pushed the fix/emit-using-version-covering-all-features branch from 3645ede to 118cde4 Compare September 5, 2023 21:18
@dtzSiFive
Copy link
Member Author

Thanks! This lets us test these using/through firtool! 👍 .

@dtzSiFive dtzSiFive merged commit e08b905 into chipsalliance:main Sep 6, 2023
@dtzSiFive dtzSiFive deleted the fix/emit-using-version-covering-all-features branch September 6, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Code Generation Affects backend code generation, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants