Deprecate calling .viewAs on non-hardware #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
added
the
Deprecation
It's an error in most cases already, and in the cases it isn't, make it a warning. Also fix a crash that could occur when viewing a non-Data containing non-hardware Data.
jackkoenig
force-pushed
the
deprecate-non-hardware-viewas
branch
from
068fffb to
552fa2b
Compare
14 tasks
seldridge
approved these changes
Jun 29, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
It's an error in most cases already, and in the cases it isn't, make it a warning. Also fix a crash that could occur when viewing a non-Data containing non-hardware Data. (cherry picked from commit 1e524de) # Conflicts: # src/test/scala/chiselTests/experimental/DataView.scala
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
It's an error in most cases already, and in the cases it isn't, make it a warning. Also fix a crash that could occur when viewing a non-Data containing non-hardware Data. (cherry picked from commit 1e524de) # Conflicts: # src/test/scala/chiselTests/experimental/DataView.scala
This was referenced Jun 29, 2023
mergify bot
added a commit
that referenced
this pull request
Jun 29, 2023
* Deprecate calling .viewAs on non-hardware (#3395) It's an error in most cases already, and in the cases it isn't, make it a warning. Also fix a crash that could occur when viewing a non-Data containing non-hardware Data. (cherry picked from commit 1e524de) # Conflicts: # src/test/scala/chiselTests/experimental/DataView.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jun 29, 2023
* Deprecate calling .viewAs on non-hardware (#3395) It's an error in most cases already, and in the cases it isn't, make it a warning. Also fix a crash that could occur when viewing a non-Data containing non-hardware Data. (cherry picked from commit 1e524de) # Conflicts: # src/test/scala/chiselTests/experimental/DataView.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an error in most cases already, and in the cases it isn't, make it a warning. Also fix a crash that could occur when viewing a non-Data containing non-hardware Data.
I will immediately follow this PR with one turning it into an error, but I want to fix the crash in Chisel 5 and 3.6 because the errors are super opaque.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Also fix a crash that could occur when viewing a non-Data containing non-hardware Data.
Reviewer Checklist (only modified by reviewer)
3.5.xor3.6.xdepending on impact, API modification or big change:5.0.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.