Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to firtool 1.38.0 #3179

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Bump to firtool 1.38.0 #3179

merged 1 commit into from
Apr 13, 2023

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Dependency update

Desired Merge Strategy

  • Squash

Release Notes

See firtool release notes.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Dependency Update Updates a dependency, will be included in release notes label Apr 13, 2023
@jackkoenig
Copy link
Contributor Author

It seems firtool's command-line arguments used by Chisel have changed again. In concert with asking the firtool devs to exercise a little more discretion in changing them, we should handle some amount of decoupling in Chisel as well. We can detect and adjust our command-line arguments based on the firtool version.

The bigger issue is how to test against multiple versions without blowing up CI compute needs. At least CI is a bit faster now--it may be worth backporting those changes to 3.6.x which probably ought to be tested against multiple firtool versions.

@jackkoenig
Copy link
Contributor Author

Not backporting this, firtool 1.38.0 support for the 3.6.x line will be done separately.

@jackkoenig jackkoenig merged commit 90e92be into main Apr 13, 2023
@jackkoenig jackkoenig deleted the bump-firtool branch April 13, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency Update Updates a dependency, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant