-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .exclude to Connectable #3172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs make sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but 1 request and 1 question.
cadf385
to
801d0f5
Compare
(cherry picked from commit 4b891ec)
(cherry picked from commit 4b891ec) Co-authored-by: Adam Izraelevitz <[email protected]>
Added a
.exclude
mechanism toConnectable
, allowing fields to always be ignored by any connectable operator.This is useful for omitting all
Analog
types from a bundle, prior to connecting it. I believe we should then make the directioned operators (:=
,:#=
,:<>=
etc.) just error if it encounters anAnalog
type, but that can be a future PR.This also jives with #3088 as probe types should also be omitted, as they have their own "connection-like" API called
define
.Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Added
.exclude
mechanism onConnectable
to enable never connecting to/from the marked fields using any connectable operator.Reviewer Checklist (only modified by reviewer)
3.5.x
or3.6.x
depending on impact, API modification or big change:5.0.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.