Deprecate forceName Component APIs, Transform #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate implementation details related to the loadMemoryFromFile API. Specifically, deprecate the Chisel-level annotation and the SFC transform while preserving the Chisel APIs. The Annotation will, after Chisel 3.6 be made private and the transform will be deleted. Signed-off-by: Schuyler Eldridge <[email protected]>
Deprecate forceName APIs on components. These are only supported on modules/instances in the MFC. (This could be revived in the future if desired.) Deprecate the ForceNamesTransform. This doesn't need to be public given that the forceName Chisel API is available to users. Signed-off-by: Schuyler Eldridge <[email protected]>
Base automatically changed from
dev/seldridge/deprecate-loadMemoryFromFile-infra
to
master
February 9, 2023 17:34
jackkoenig
approved these changes
Feb 9, 2023
|
oh now i see this can dismiss my question on #2988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate forceName APIs on components. These are only supported on modules/instances in the MFC. (This could be revived in the future if desired.)
Deprecate the ForceNamesTransform. This doesn't need to be public given that the forceName Chisel API is available to users.
Signed-off-by: Schuyler Eldridge [email protected]
This PR is stacked on #2986.