Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify mismatched width error message #2917

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

azidar
Copy link
Contributor

@azidar azidar commented Jan 3, 2023

Minor change to enable a clearer mismatched widths error message.

Contributor Checklist

  • [N/A] Did you add Scaladoc to every public function/method?
  • [N/A] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [N/A] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code cleanup

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@azidar azidar requested a review from jackkoenig January 3, 2023 21:45
@azidar azidar enabled auto-merge (squash) January 3, 2023 21:45
@jackkoenig jackkoenig added this to the 3.6.0 milestone Jan 3, 2023
@azidar azidar merged commit 8b226a0 into master Jan 3, 2023
@azidar azidar deleted the clarify-truncation-error-msg branch January 3, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants