Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account opaque members in squeeze functions #2904

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Take into account opaque members in squeeze functions #2904

merged 1 commit into from
Dec 20, 2022

Conversation

trilorez
Copy link
Contributor

This updates the Connectable.squeeze* functions to handle opaque types. Before, squeezing an opaque type would not affect it's underlying element. Now, squeezing an opaque type will squeeze it's underlying element.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API improvement

API Impact

Using squeeze with OpaqueType members will squeeze their underlying elements, as opposed to not affecting them.

Backend Code Generation Impact

None

Desired Merge Strategy

  • Squash: The PR will be squashed and merged

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.


/** Select members of base to squeeze
*
* @param members functions given the base return a member to squeeze
*/
def squeeze(members: (T => Data)*): Connectable[T] = this.copy(squeezed = squeezed ++ members.map(f => f(base)).toSet)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't incude toSet in the updates since set concatenation is being performed against squeeze anyway

Copy link
Contributor

@azidar azidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azidar azidar merged commit 42062be into chipsalliance:master Dec 20, 2022
@jackkoenig jackkoenig added this to the 3.6.0 milestone Dec 20, 2022
@trilorez trilorez deleted the opaque-squeeze branch December 29, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants