Make PriorityMux stack safe #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
commented
Nov 18, 2022
Comment on lines
1
to
+4
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package chiselTests.util | ||
|
|
There was a problem hiding this comment.
this change is unrelated but I opened this file to copy it for making the PriorityMuxSpec and noticed the license comment was in the wrong spot.
It used to be implemented with recursion, now it's implemented with a stack safe reverse and foldLeft. Also there were no tests for PriorityMux so I added one which helps prove the change is functionally correct.
jackkoenig
force-pushed
the
stack-safe-prioritymux
branch
from
64be121 to
4e7eac7
Compare
aswaterman
approved these changes
Nov 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2022
It used to be implemented with recursion, now it's implemented with a stack safe reverse and foldLeft. Also there were no tests for PriorityMux so I added one which helps prove the change is functionally correct. (cherry picked from commit 269ce47) # Conflicts: # src/test/scala/chiselTests/util/PipeSpec.scala
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2022
* Make PriorityMux stack safe (#2854) It used to be implemented with recursion, now it's implemented with a stack safe reverse and foldLeft. Also there were no tests for PriorityMux so I added one which helps prove the change is functionally correct. (cherry picked from commit 269ce47) # Conflicts: # src/test/scala/chiselTests/util/PipeSpec.scala * Resolve backport conflicts Co-authored-by: Jack Koenig <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be implemented with recursion, now it's implemented with a stack safe reverse and foldLeft.
Also there were no tests for PriorityMux so I added one which helps prove the change is functionally correct.
Contributor Checklist
docs/src?Type of Improvement
API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
PriorityMuxis now stack-safe and will not require users to increase their JVM's stack size when called with large inputs.Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.