Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on fatal warnings in mdoc documentation #2146

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Turn on fatal warnings in mdoc documentation #2146

merged 1 commit into from
Oct 4, 2021

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.4.x milestone Oct 4, 2021
@jackkoenig jackkoenig merged commit df76831 into master Oct 4, 2021
@jackkoenig jackkoenig deleted the mdoc-fatal-warnings branch October 4, 2021 23:57
mergify bot pushed a commit that referenced this pull request Oct 4, 2021
@jackkoenig
Turn on fatal warnings in mdoc documentation (#2146)
f4379be 
(cherry picked from commit df76831)

# Conflicts:
#	build.sbt
@mergify mergify bot mentioned this pull request Oct 4, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label Oct 4, 2021
mergify bot added a commit that referenced this pull request Oct 5, 2021
@mergify @jackkoenig
Turn on fatal warnings in mdoc documentation (backport #2146) (#2148)
6e7d1c5 
* Turn on fatal warnings in mdoc documentation (#2146)

(cherry picked from commit df76831)

# Conflicts:
#	build.sbt

* Resolve merge conflicts

Co-authored-by: Jack Koenig <[email protected]>
jackkoenig added a commit that referenced this pull request Feb 28, 2023
@jackkoenig @mergify
Deprecate InlineCasts, add InlineAcrossCasts (#2146)
9a3dcf7 
To maintain binary compatibility, InlineAcrossCasts is just aliases to
the now deprecated InlineCasts. We can make the binary incompatible
change of renaming the class and object for 1.5.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azidar azidar azidar approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @azidar