Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using switch without importing SwitchContext #1595

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Support using switch without importing SwitchContext #1595

merged 1 commit into from
Sep 22, 2020

Conversation

jackkoenig
Copy link
Contributor

Fixes ucb-bar/chisel-tutorial#166

Just a minor issue where switch basically assumes you're always doing import chisel3.util._. Simple fix.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

Fixes a bug in API

Backend Code Generation Impact

None

Desired Merge Strategy

  • Squash

Release Notes

Fix bug where using chisel3.util.switch required the user to import chisel3.util.SwitchContext

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.2.x milestone Sep 22, 2020
@jackkoenig jackkoenig requested a review from a team as a code owner September 22, 2020 01:06
@jackkoenig jackkoenig requested review from ducky64 and removed request for a team September 22, 2020 01:06
@seldridge seldridge added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Sep 22, 2020
@mergify mergify bot merged commit 9c4f14f into master Sep 22, 2020
mergify bot pushed a commit that referenced this pull request Sep 22, 2020
@jackkoenig
Support using switch without importing SwitchContext (#1595)
11cb7c7 
(cherry picked from commit 9c4f14f)

# Conflicts:
#	docs/src/wiki-deprecated/cookbook.md
#	src/test/scala/chiselTests/SwitchSpec.scala
@mergify mergify bot mentioned this pull request Sep 22, 2020
Merged
mergify bot pushed a commit that referenced this pull request Sep 22, 2020
@jackkoenig
Support using switch without importing SwitchContext (#1595)
536ec53 
(cherry picked from commit 9c4f14f)

# Conflicts:
#	docs/src/wiki-deprecated/cookbook.md
@mergify mergify bot mentioned this pull request Sep 22, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported label Sep 22, 2020
@jackkoenig jackkoenig deleted the fix-switch branch October 17, 2020 22:57
mergify bot added a commit that referenced this pull request Nov 11, 2020
@mergify @jackkoenig
Support using switch without importing SwitchContext (bp #1595) (#1597)
aae0ba9 
* Support using switch without importing SwitchContext (#1595)

(cherry picked from commit 9c4f14f)

# Conflicts:
#	docs/src/wiki-deprecated/cookbook.md

* Resolve merge conflicts

Co-authored-by: Jack Koenig <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Nov 11, 2020
@mergify @jackkoenig
Support using switch without importing SwitchContext (bp #1595) (#1596)
8ce954f 
* Support using switch without importing SwitchContext (#1595)

(cherry picked from commit 9c4f14f)

# Conflicts:
#	docs/src/wiki-deprecated/cookbook.md
#	src/test/scala/chiselTests/SwitchSpec.scala

* Resolve merge conflicts

Co-authored-by: Jack Koenig <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jackkoenig added a commit that referenced this pull request Feb 28, 2023
@jackkoenig @albert-magyar
[Mergify] Add back backporting to 1.2.x (#1595)
498b833 
Labeling a PR with Milestone 1.2.X now will tell Mergify to backport it
to both 1.2.x and 1.3.x.

Co-authored-by: Albert Magyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@ducky64 ducky64 Awaiting requested review from ducky64

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.

not found: type SwitchContext
2 participants
@jackkoenig @seldridge