Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use caching to reduce number of expensive lookups. Also make methods private so we can improve them without breaking binary compatibility
I think this could be better, like only doing a single lookup, but I was having trouble getting it working so thought it better to just get this out here. This reduces the runtime of the Chisel plugin in rocket-chip compile by quite a bit (collected with scalacOption
-Ystatistics
):Typer included for reference (also shows how noisy the measurements are).
With this change, chiselcomponent is generally 2-4x faster.
Contributor Checklist
docs/src
?Type of Improvement
API Impact
Some methods that shouldn't have been public in the compiler plugin are now private
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Improve performance of the Chisel Scalac compiler plugin over that in 3.4.0-RC1
Reviewer Checklist (only modified by reviewer)
Please Merge
?