Fix load memory from file to work with binary #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed in hexOrBinary parameter to ChiselLoadMemoryAnnotation
|
|
…ith-binary' into fix-loadMemoryFromFile-to-work-with-binary
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2020
* fix loadMemoryFromFile to work with binary Passed in hexOrBinary parameter to ChiselLoadMemoryAnnotation * Added test for binary format support in loadMemoryFromFile * Added test for binary format support in loadMemoryFromFile (cherry picked from commit 88265ee)
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2020
* fix loadMemoryFromFile to work with binary Passed in hexOrBinary parameter to ChiselLoadMemoryAnnotation * Added test for binary format support in loadMemoryFromFile * Added test for binary format support in loadMemoryFromFile (cherry picked from commit 88265ee)
mergify bot
added a commit
that referenced
this pull request
Sep 9, 2020
* fix loadMemoryFromFile to work with binary Passed in hexOrBinary parameter to ChiselLoadMemoryAnnotation * Added test for binary format support in loadMemoryFromFile * Added test for binary format support in loadMemoryFromFile (cherry picked from commit 88265ee) Co-authored-by: HappyQuark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed in hexOrBinary parameter to ChiselLoadMemoryAnnotation
Test included
Fixes #1582
API Impact
No change in API
Backend Code Generation Impact
Allows $readmemb to be generated when the user specifies MemoryLoadFileType.Binary.
Desired Merge Strategy
Squash
Release Notes
Fixed bug in loadMemoryFromFile that caused the hexOrBinary parameter to be ignored.