Added website docs and mdoc. #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're just doing this so that you get git credit for all of these lines.... 🤔 🧐 🕵️♂️ |
|
Well SOMEBODY's gotta get that git credit, eh?? :P |
|
lol |
seldridge
requested changes
Aug 20, 2020
There was a problem hiding this comment.
Looks great! I didn't look at the content of any of the *.md files as I was assuming that they're all the same. If there's anything that I should be looking at there, let me know.
Two change requests:
- The logo moving should be reflected in the top-level README.md
- Add an
sbt docs/mdoctask to CircleCI
debs-sifive
reviewed
Aug 21, 2020
debs-sifive
reviewed
Aug 21, 2020
debs-sifive
reviewed
Aug 21, 2020
seldridge
reviewed
Aug 21, 2020
azidar
added
the
Please Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: documentation
Impact: no functional change
Development Phase: implementation
Release Notes
Added living documentation with repository. This will enable us to enforce better documentation of new features as part of their upstream process.