Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions in README #1524

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

nullobject
Copy link
Contributor

@nullobject nullobject commented Jul 28, 2020

The instructions for building Chisel locally don't include anything about firrtl or treadle.

I have updated the README to reflect the real steps.

Related issue: #1523
Type of change: documentation

Fixes #1523

@nullobject nullobject force-pushed the update-build-instructions branch from f487955 to 04a6fd9 Compare July 28, 2020 07:03
@nullobject nullobject marked this pull request as ready for review July 28, 2020 07:05
@nullobject nullobject requested a review from a team as a code owner July 28, 2020 07:05
@nullobject nullobject force-pushed the update-build-instructions branch from 04a6fd9 to 4183b5a Compare July 29, 2020 10:17
@nullobject nullobject force-pushed the update-build-instructions branch 2 times, most recently from efcabeb to 8d0b91f Compare July 29, 2020 22:07
@nullobject nullobject requested a review from edwardcwang July 29, 2020 22:07
@nullobject nullobject force-pushed the update-build-instructions branch from 8d0b91f to a0b0ee1 Compare July 29, 2020 22:07
The instructions for building Chisel locally didn't include anything about firrtl or treadle.

The steps are:

1. publishLocal current working copy of FIRRTL
2. publishLocal current working copy of Treadle
3. sbt test in chisel3
@nullobject nullobject force-pushed the update-build-instructions branch from a0b0ee1 to 8bbfd5b Compare July 29, 2020 22:19
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jul 29, 2020
@jackkoenig
Copy link
Contributor

Thanks @nullobject!

@mergify mergify bot merged commit 8aeb39b into chipsalliance:master Jul 29, 2020
@nullobject nullobject deleted the update-build-instructions branch July 29, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building chisel locally is broken
3 participants