Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scalastyle configurations #1519

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Remove scalastyle configurations #1519

merged 2 commits into from
Jul 22, 2020

Conversation

albert-magyar
Copy link
Contributor

See chipsalliance/firrtl#1767, we will be moving to scalafmt and will do one big "auto-cleanup" right before 1.4.

Type of change: other enhancement

@albert-magyar albert-magyar requested a review from a team as a code owner July 20, 2020 19:24
@albert-magyar albert-magyar requested a review from jackkoenig July 20, 2020 19:33
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.
I am curious as to why you removed the //scalastyle: from just 22 of the files.

* Drop plugin
* Drop scalastyle tests from make recipes
* Remove checkstyle from CI
@albert-magyar
Copy link
Contributor Author

This looks fine.
I am curious as to why you removed the //scalastyle: from just 22 of the files.

Good point, I mistakenly only applied the scripts to src! Fixed now, thanks.

@albert-magyar albert-magyar force-pushed the no-scalastyle branch 2 times, most recently from 04870ca to e5568f5 Compare July 21, 2020 23:30
@albert-magyar albert-magyar merged commit 473a138 into master Jul 22, 2020
@albert-magyar albert-magyar deleted the no-scalastyle branch July 22, 2020 00:40
@albert-magyar albert-magyar added this to the 3.4.0 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants