Fix TesterDriver.scala regression #1481 #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
revert-TesterDriver
branch
from
77b0659 to
b8b2d6b
Compare
Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
revert-TesterDriver
branch
from
b8b2d6b to
09c95a5
Compare
seldridge
changed the title
seldridge
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2020
Signed-off-by: Schuyler Eldridge <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a1edc8f)
mergify bot
added a commit
that referenced
this pull request
Jun 24, 2020
Signed-off-by: Schuyler Eldridge <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a1edc8f) Co-authored-by: Schuyler Eldridge <[email protected]>
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Split Passes.scala into separate files * Add imports of implicit things Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts changes toTesterDriverintroduced in #1481 that broke chisel-testers.Fix a regression in chisel-iotesters introduced in #1481. This restored a mistakenly removed call to
finishWrapper.Related issue: #1481 (comment)
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
None.