-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mill build #1324
fix mill build #1324
Conversation
As for accessing by other
we can give a
to make |
@@ -1,249 +1,134 @@ | |||
import ammonite.ops._ | |||
import ammonite.ops.ImplicitWd._ | |||
import coursier.MavenRepository | |||
import mill._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a line above this saying what mill version this has been tested with?
19be93c
to
d01a723
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested at https://github.com/edwardcwang/chisel-bleeding-edge-test and it appears to work exactly as expected.
Any update for this PR? |
Co-authored-by: Albert Magyar <[email protected]>
Related issue: #1291 #1035
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
Bug fix for mill build system, original mill has been deprecated since the update of mill.
This implementation use native mill API as much as possible, which can keep better compatibility to which.