Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mill build #1324

Merged
merged 3 commits into from
Feb 13, 2020
Merged

fix mill build #1324

merged 3 commits into from
Feb 13, 2020

Conversation

sequencer
Copy link
Member

Related issue: #1291 #1035

Type of change: bug report

Impact: no functional change

Development Phase: implementation

Release Notes
Bug fix for mill build system, original mill has been deprecated since the update of mill.
This implementation use native mill API as much as possible, which can keep better compatibility to which.

@sequencer sequencer requested a review from a team as a code owner February 7, 2020 04:39
@sequencer sequencer changed the title add mill build fix mill build Feb 7, 2020
@claassistantio
Copy link

claassistantio commented Feb 7, 2020

CLA assistant check
All committers have signed the CLA.

@sequencer
Copy link
Member Author

As for accessing by other build.sc, for example there is a project structure in:

|proj
|-chisel3
|-firrtl

we can give a build.sc under proj,

import $file.chisel3.build
import $file.firrtl.build

object myfirrtl extends firrtl.build.firrtlCrossModule("2.12.10") {
  override def millSourcePath = super.millSourcePath / 'firrtl
}

object mychisel3 extends chisel3.build.chisel3CrossModule("2.12.10") {
  override def millSourcePath = super.millSourcePath / 'chisel3
  def firrtlModule: Option[PublishModule] = Some(myfirrtl)
}

object foo extends ScalaModule {
  def moduleDeps = Seq(mychisel3)
}

to make mychisel3 depend on myfirrtl. Then foo can depend on the mychisel3.

@@ -1,249 +1,134 @@
import ammonite.ops._
import ammonite.ops.ImplicitWd._
import coursier.MavenRepository
import mill._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a line above this saying what mill version this has been tested with?

@sequencer sequencer force-pushed the mill branch 2 times, most recently from 19be93c to d01a723 Compare February 10, 2020 19:51
Copy link
Contributor

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested at https://github.com/edwardcwang/chisel-bleeding-edge-test and it appears to work exactly as expected.

@edwardcwang edwardcwang added the Squash and merge These commits don't matter, squash and merge label Feb 11, 2020
@sequencer
Copy link
Member Author

Any update for this PR?

@edwardcwang edwardcwang merged commit 84e5e77 into chipsalliance:master Feb 13, 2020
@sequencer sequencer deleted the mill branch February 13, 2020 19:22
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash and merge These commits don't matter, squash and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants