Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big decimal methods for num types.2 #1309

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Big decimal methods for num types.2 #1309

merged 2 commits into from
Jan 23, 2020

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Jan 23, 2020

Cosmetic changes - update comments, use MaxBitsBigIntToBigDecimal instead of '108'.

@ucbjrl ucbjrl requested a review from chick January 23, 2020 17:28
@ucbjrl ucbjrl requested a review from a team as a code owner January 23, 2020 17:28
@ucbjrl ucbjrl removed the request for review from a team January 23, 2020 17:29
chick
chick approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ever better

@ucbjrl ucbjrl merged commit 481736c into big-decimal-methods-for-num-types Jan 23, 2020
@ucbjrl ucbjrl deleted the big-decimal-methods-for-num-types.2 branch January 23, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick chick chick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ucbjrl @chick