Fix Queue.apply for size 0 in chisel3._ code #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof. |
aswaterman
approved these changes
Sep 12, 2019
chick
approved these changes
Sep 12, 2019
jackkoenig
force-pushed
the
fix-queue-apply
branch
from
55ddd9e to
2e8b07f
Compare
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
Adds a space to correct in an exception message. Corrects capitalization in Github to it's official name (GitHub) and adds a link to file an issue. Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incredibly, this didn't work (in
import chisel3.) and may never have worked.This really ought to go in to 3.2
Related issue:
Type of change: bug fix
Impact: no functional change
Development Phase: implementation
Release Notes