Submit VerifyConnectionProperties.scala as a separate PR #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move VerifyConnectionProperties.scala from #1056 to its own PR.
|
This will fail tests until #1056 is merged. |
jackkoenig
added a commit
that referenced
this pull request
Feb 28, 2023
Fix minor regression from #1124
|
Replaced by Connectable and related tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move VerifyConnectionProperties.scala from #1056 to its own PR.
Related issue: #1056
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Provide a suite of tests that codify current connection semantics to document and detect unintended modifications.