Avoid silently truncating BigInt to Int #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
force-pushed
the
safe-cast-from-bigint
branch
from
2b5b360 to
b616a39
Compare
edwardcwang
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
Appears sane to me and passes tests. @ducky64 @jackkoenig Any comments?
ducky64
approved these changes
Apr 15, 2019
|
There are still some places we'd need to truncate to Int, e.g. since Vecs are backed by Scala Vectors. And other CAD tools barf on very wide Verilog arrays anyway. So, I don't think switching to BigInts internally would bear much fruit. |
- Introduce internal helper `castToInt`, which issues an error when the input BigInt can't be represented as Int. - Use `castToInt` wherever we were using `toInt` in a potentially unsafe way.
edwardcwang
force-pushed
the
safe-cast-from-bigint
branch
from
850dc78 to
5039e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce internal helper
castToInt, which issues an error when the inputBigInt can't be represented as Int.
Use
castToIntwherever we were usingtoIntin a potentially unsafe way.Technically, this is an API modification, since previously users could have done such things as
UInt.apply(BigInt.pow(2, 32)), which would have silently wrapped around and extracted bit 0.Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes