Don't recompile dpe every single time #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
requested review from
korran,
jhand2,
mhatrevi,
JohnTraverAmd,
clundin25 and
varuns-nvidia
|
Thanks! Looks like there is a clippy complaint |
clundin25
previously approved these changes
Feb 3, 2025
The build script always writes to `arbitrary_max_handles.rs`, which means that a recompile is always required. This then triggers a rebuild of any project (i.e., Caliptra) that uses this. This fixes is so that we only write the file if the contents need to be changed, so the build can be cached. Clippy fix
swenson
force-pushed
the
dont-recompile-every-time
branch
from
73fbceb to
3efa5ec
Compare
mhatrevi
approved these changes
Feb 3, 2025
clundin25
approved these changes
Feb 3, 2025
|
Thanks! |
|
Could one of you merge? I do not appear to have permission. |
jhand2
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script always writes to
arbitrary_max_handles.rs, which means that a recompile is always required.This then triggers a rebuild of any project (i.e., Caliptra) that uses this.
This fixes it so that we only write the file if the contents need to be changed, so the build can be cached.