Feature/sidebar refactor

[timothyrusso]

Description

Refactor some UI problems related to the Sidebar after removing Daisy UI.

• Performance improvements
• Add the component to Storybook (Important: the component do not have any props, so there are no docs in storybook, only the user interaction to open and close the Sidebar)
• Fix some layout problems

Important:
Buttons must be fixed, I will wait for the merge of the PR that refactor the Button component so I will use it to fix the buttons in the Sidebar.

Issue link

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
chingu-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Jan 30, 2024 5:52am

[Dan-Y-Ko]

The button refactor pr has been merged so you can update this pr as needed now.

[Dan-Y-Ko]

There's some changes needed for the buttons. Right now the button component isn't really being used and just ton of classes being added to it. I think we need a separate button component for those, like icon button in the figma, but it doesn't seem like it's in a completed state so I need to talk to Eury about this.

[Dan-Y-Ko]

Almost there!

Just some minor changes.

1. Can you remove the cursor pointer on the myvoyage hover effect if the user is not part of active voyage or logged in. So basically when the lock appears.
2. in the button component, in the neutral variant, change the focus to active.
3. The tooltip became weird in your updated branch. EDIT: you can just move the tooltip to wrap around the button and not the element.icon. That fixes it.

[timothyrusso]

Almost there!

Just some minor changes.

1. Can you remove the cursor pointer on the myvoyage hover effect if the user is not part of active voyage or logged in. So basically when the lock appears.
2. in the button component, in the neutral variant, change the focus to active.
3. The tooltip became weird in your updated branch. EDIT: you can just move the tooltip to wrap around the button and not the element.icon. That fixes it.

@Dan-Y-Ko Done!

[Dan-Y-Ko]

The logic to check for current voyage needs to change (again). Can just check for existence of an active status in the voyage status.

I tested with some method, you can use something else if it's better.

[Dan-Y-Ko]

lgtm :)