-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: added new user checklist items #243
Conversation
d3cb40f
to
d0617ab
Compare
I don't think this would be considered a refactor. Maybe feature, since it added new things like a new field in the database. |
Yes we can consider it as feature |
@timDeHof, @cherylli, @davideastmond, @jenny-alexander |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good,
all things in the ticket taken care of
I ran all tests and all passed
Just a note: I think "Let's learn more about you" is when they submitted their first part of the application form which will be shown after they signup, we can add this after we complete the application form. I might add a task/subtask for it on click up
Okay, once the form part is completed, I will add it to the checklist as well. |
Description
emailVerified
field in the response to check if the user is verified.hasCompletedAssessment
field to User schema to check for completion of assessments.soloProjects
array containingid
andstatus
to the responseIssue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Swagger
to receive the checklist items in/me
endpointyarn test:docker
to pass all the e2e and unit testsChecklist: