Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added new user checklist items #243

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

Ajen07
Copy link
Contributor

@Ajen07 Ajen07 commented Feb 18, 2025

Description

  • Added emailVerified field in the response to check if the user is verified.
  • Added hasCompletedAssessment field to User schema to check for completion of assessments.
  • Added soloProjects array containing id and status to the response

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested using Swagger to receive the checklist items in /me endpoint
  • Tested with yarn test:docker to pass all the e2e and unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 added the review label Feb 18, 2025
@Ajen07 Ajen07 self-assigned this Feb 18, 2025
@Ajen07 Ajen07 requested review from cherylli and removed request for cherylli February 18, 2025 05:50
@Ajen07 Ajen07 force-pushed the refractor/add-new-user-checklist branch from d3cb40f to d0617ab Compare February 18, 2025 05:53
@Ajen07 Ajen07 requested a review from cherylli February 18, 2025 05:56
@cherylli
Copy link
Contributor

I don't think this would be considered a refactor. Maybe feature, since it added new things like a new field in the database.
Maybe a chore if it's not big enough to consider a feature?

@Ajen07 Ajen07 changed the title Refactor: added new user checklist items Feat: added new user checklist items Feb 18, 2025
@Ajen07
Copy link
Contributor Author

Ajen07 commented Feb 18, 2025

I don't think this would be considered a refactor. Maybe feature, since it added new things like a new field in the database. Maybe a chore if it's not big enough to consider a feature?

Yes we can consider it as feature

Copy link
Contributor

@timDeHof, @cherylli, @davideastmond, @jenny-alexander
One business day has passed since the review started. Give priority to reviews as much as possible.

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good,
all things in the ticket taken care of
I ran all tests and all passed

Just a note: I think "Let's learn more about you" is when they submitted their first part of the application form which will be shown after they signup, we can add this after we complete the application form. I might add a task/subtask for it on click up

@Ajen07
Copy link
Contributor Author

Ajen07 commented Feb 19, 2025

code looks good, all things in the ticket taken care of I ran all tests and all passed

Just a note: I think "Let's learn more about you" is when they submitted their first part of the application form which will be shown after they signup, we can add this after we complete the application form. I might add a task/subtask for it on click up

Okay, once the form part is completed, I will add it to the checklist as well.

@Ajen07 Ajen07 merged commit 60e140c into dev Feb 19, 2025
1 check passed
@Ajen07 Ajen07 deleted the refractor/add-new-user-checklist branch February 19, 2025 13:27
cherylli added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants