Tests/ideations unit tests #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or better coverage The tests for the ideations controller have been refactored to improve readability and maintainability. New tests have been added to ensure all methods in the controller are tested. This includes tests for createIdeation, createIdeationVote, getIdeationsByVoyageTeam, updateIdeation, deleteIdeation, deleteIdeationVote, setIdeationSelection, and resetIdeationSelection. The mock data and service have also been updated to better reflect the actual data and service. This will help to catch any potential issues or bugs in the future.
The changelog has been updated to reflect the recent changes in the project. This includes the addition of the same site property to the clear cookies function and the creation of routes for teams to create their own tech stack categories. The cors origin list has been updated and the unit tests for the ideations controller and services have been refactored. This documentation update ensures that the changelog accurately represents the current state of the project.
…move unused variables The unused variables 'ideationArr' and 'ideationVoteArr' were removed from both ideations.controller.spec.ts and ideations.service.spec.ts. Also, the unused import 'ConflictException' was removed from ideations.service.spec.ts. These changes were made to clean up the code and improve readability.
JoshuaHinman
approved these changes
Oct 29, 2024
cherylli
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the ideations unit tests for the controller and services. It refactors the test files to use prisma mock package and updated to test new services. Both tests follow the requirements found in the wiki.
Issue link
#86azu6kwc
Type of change
How Has This Been Tested?
Run command
yarn test:unit ideationsoryarn test:unit:docker ideationsChecklist: