Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: unit tests for Team resources #201

Merged
merged 15 commits into from
Sep 19, 2024
Merged

Test: unit tests for Team resources #201

merged 15 commits into from
Sep 19, 2024

Conversation

Ajen07
Copy link
Contributor

@Ajen07 Ajen07 commented Sep 16, 2024

Description

  • Unit test for Team Resource services and controller

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • test with yarn test:docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 added the review label Sep 16, 2024
@Ajen07 Ajen07 requested a review from cherylli September 16, 2024 11:12
@Ajen07 Ajen07 self-assigned this Sep 16, 2024
@cherylli cherylli requested a review from timDeHof September 16, 2024 20:59
timDeHof
timDeHof previously requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the tests passed but I added some suggestions for both unit tests that would help with the readability and maintainability of your tests.

@Ajen07 Ajen07 requested a review from timDeHof September 17, 2024 11:15
cherylli
cherylli approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@cherylli cherylli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good! All tests passed locally for me

timDeHof
timDeHof approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests passed. Thank you for making the changes! it looks great!

@Ajen07 Ajen07 merged commit e1b8dbb into dev Sep 19, 2024
1 check passed
@Ajen07 Ajen07 deleted the test/unit-test-resources branch September 19, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timDeHof timDeHof timDeHof approved these changes

@cherylli cherylli cherylli approved these changes

Assignees

@timDeHof timDeHof

@Ajen07 Ajen07

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ajen07 @timDeHof @cherylli