-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/discord oauth p2 - functionality #194
Conversation
…to feature/discord-oauth-p2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All unit and e2e test pass and 0authProvider in the database shows discord in the model
@timDeHof need a re-review if you can please, resolved changelog conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Discord login flow is working well, and new user is being added to the database correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every unit & e2e tests passed. Also able to login into the dashboard using discord
Description
Add discord login functionality, go to http://localhost:8000/api/v1/auth/discord/login, a discord login / authorize screen will pop up, click authorize and it will grant access token, refresh token and then redirect to the frontend url
It gets the user discord email,
Currently, if the user has different emails for credentials, and differnet oauth, it will create different accounts as we have no way to match users with different emails. In future, we should make it so user can link their social accounts to their existing email, this way, we can link their accounts without needing to match their emails
Issue link
Type of change
How Has This Been Tested?
Login, and check access_token, refresh_token in cookies
Make sure to db seed before testing, discord needs to be in the oauthProvider table otherwise it will generate an error
Checklist: