Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swagger access info and form endpoint permissions #160

Merged
merged 6 commits into from
Jun 8, 2024

Conversation

cherylli
Copy link
Contributor

@cherylli cherylli commented Jun 4, 2024

Description

Updated swagger endpoint descriptions for auth, and forms
Add permission to forms

Only part of the task as I don't want the PR to get to big

CASL notes for reference: https://suwanna.atlassian.net/wiki/spaces/SD/pages/76349451/CASL

Issues:
It seems prisma/casl doesn't support matching nested values (https://casl.js.org/v5/en/guide/conditions-in-depth#match-nested-property-value)
so I have used a workaround instead

Issue link

https://app.clickup.com/t/86azr0q42

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested on swagger, and yarn test:docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this Jun 4, 2024
curtwl
curtwl previously approved these changes Jun 6, 2024
Copy link
Contributor

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Ajen07
Ajen07 previously approved these changes Jun 6, 2024
Copy link
Contributor

@Ajen07 Ajen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the new permissions are working as expected .

@cherylli cherylli dismissed stale reviews from Ajen07 and curtwl via 63e743e June 7, 2024 21:35
@cherylli cherylli merged commit 7bacea2 into dev Jun 8, 2024
1 check passed
@cherylli cherylli deleted the chore/swagger-access-info branch June 8, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants