-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: sprint checkin form submission status for user #149
Feature: sprint checkin form submission status for user #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: move to review comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't need to add any field to the table, we can retrieve the data without added another field to the table
you can retrieve the data from sprint check in table and append it to the /me endpoint
we don't want to add extra/unnecessary columns to tables, we need to make use of the relations
I guess one thing to keep in mind is we don't want to create duplicate data just for the purpose of retrieval.
====
So to reiterate,
in the fetch user detail endpoint users/me
,
fetch the users voyageTeamMemberId, use this id to query sprintCheckin table, append this data to the response, so something like this
prisma.FormResponseCheckin.findMany({
where: voyageTeamMemberId {
id: { in: voyageTeamMemberId}
}, seleect:{
sprintId: true
}
where voyageTeamMemberId is the list of Id from the user table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed and checkins displayed in response - nice job! It would have been helpful for the users/me route to be identified in the Description or Tested section - at first I assumed it was the sprints/checkin route
prisma/migrations/20240507131015_add_sprint_checkin_for_user/migration.sql
Outdated
Show resolved
Hide resolved
sorry I forgot to submit my reviews which I did a couple of days ago, so they were pending |
Got it ! .From the next time , I will make my descriptions more elaborative about the issue and its solutions . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! All tests passes and swagger endpoint responses with a 201.
Description
added check in submission status in the response, the sprintId will be in sprintCheckin list if the user has submitted a check in form for the sprint
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
unit tests

e2e tests

swagger

Checklist: