Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor: update all form title reference #145

Merged
merged 8 commits into from
May 6, 2024

Conversation

Ajen07
Copy link
Contributor

@Ajen07 Ajen07 commented May 5, 2024

Description

All the form title reference are updated to use the values in the file formTitle.ts

Issue link

https://app.clickup.com/t/86azvdyff

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Performed unit tests
    tests passed

  • Performed e2e tests
    passed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 requested review from cherylli, timDeHof and curtwl May 5, 2024 01:29
@Ajen07 Ajen07 self-assigned this May 5, 2024
@Ajen07 Ajen07 requested a review from JoshuaHinman May 5, 2024 10:47
timDeHof
timDeHof previously approved these changes May 5, 2024
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! every test passed for me

Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed but seeding fail probably because baseUrl doesn't apply to prisma, so prisma can't find FormTitles in "src/global/constants/formTitles"

image

cherylli
cherylli previously approved these changes May 6, 2024
Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix, prisma db seed is working now and all tests passed

Copy link
Contributor

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Ajen07 Ajen07 merged commit 1fce115 into dev May 6, 2024
1 check passed
@Ajen07 Ajen07 deleted the refractor/update-all-form-title-reference branch May 6, 2024 12:41
timDeHof added a commit that referenced this pull request May 9, 2024
The changelog has been updated to include the following changes:
- A new feature has been added to the deleteFeature method. It now uses a DeleteFeatureResponse and returns an object with a successful status and a message. This change was made in pull request #150.
- Various updates and additions have been made to the test github actions workflow, form title references, and form input types. These changes were made in pull requests #143, #145, and #146 respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants