-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add POST checkin form endpoint #126
Conversation
…ature/checkin-form-endpoints
… loginAndGetToken from auth e2e tests
…ature/checkin-form-endpoints
…) in database schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Re: "do we need to check if sprintID is a reasonable sprint Id?", is that not being automatically populated in the form based on the date?
no, atm we insert sprint id and teamMemberId, so we rely on frontend giving the right sprint id. although it's not really a huge issue as there's a |
…ature/checkin-form-endpoints
f05248f
to
d31075a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Had an issues when running e2e tests that was caused by some of latest changes not able to pushed. but after that fix, all tests passed!
Description
Added POST endpoint for check in form submissions
Changes
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: