Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a re-submission of the tech selections endpoint PR, on a fresh branch with recent updates included. Previous issues should be addressed.
To apply the database changes in this PR, run
yarn migrate
andyarn push
This PR adds a new endpoint
voyages/teams/{teamId}/techs/selections
, allowing teams to designate tech stack items as "Selected" within their categories. It enforces a maximum of 3 selections per category, defined byconst MAX_SELECTION_COUNT
.The teamTechStackItem model has been updated with Boolean value isSelected.
There are e2e test for the following responses:
-200 successful update
-400 max selections per category exceeded
-400 invalid teamid
-401 unauthorized- uses old JWT test
Type of change
How Has This Been Tested?
This has been tested in swagger and with
yarn test:e2e techs
Checklist: