-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sprints test #113
Feature/sprints test #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very thorough tests, all passed locally here. thanks!
just need to resolve that changelog conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good structured tests but maybe label the test suites and specs to convey clearer intention of each unit test. I have added some suggestions for the describe
and it
blocks. I think it would make it easier for new developers to understand the intention of the unit tests.
I found this unit testing style guide that could help us keep a consist style to the tests.
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
…ingu-dashboard-be into feature/sprints-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking great. I have spotted a couple of it
statements that could be written in a way that newcomers could understand the tests better.
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
Co-authored-by: timDeHof <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
jest-extended
dependency to provideexpect.toBeOneOf()
and other useful functionsType of change
How Has This Been Tested?
yarn test:e2e sprints
Checklist: